Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't print config content by default #146

Merged
merged 4 commits into from
Nov 15, 2023
Merged

Conversation

MattWellie
Copy link
Contributor

@MattWellie MattWellie commented Nov 14, 2023

This is very petty...

The config module is currently set up to print the config contents by default each time a new config is loaded. In the pipeline startup the config content is repeated 3 times resulting in a huge wall of redundant text. This also clouds the logging for failed tests etc. and is generally not useful.

The first get_config invocation in the pipeline is easy to find, but I haven't located the subsequent 2 calls that trigger re-printing of the same content...

Instead of mucking about in the prod-pipes codebase to track down the exact calls, how do you feel about treating this at source - alter the default behaviour not to print to logging, then set get_config(True) as a deliberate action (e.g. the first time the config is loaded, then never again)

Proposal generally approved on Slack: https://centrepopgen.slack.com/archives/C018KFBCR1C/p1700002730474369

Copy link
Contributor

@illusional illusional left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in favour of this, but can we consult before we make this change. Can you post in team data, gather some feedback and we can assess based on that?

@MattWellie
Copy link
Contributor Author

Can you post in team data, gather some feedback and we can assess based on that?

Aye, I'll post tomorrow. Figured you fine folk would be a good litmus test 💪

@MattWellie MattWellie merged commit fa3a655 into main Nov 15, 2023
4 checks passed
@MattWellie MattWellie deleted the hide-config-as-default branch November 15, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants