-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[general need] V2 Codes Cleanup #191
Comments
I will start working on this ticket. I think the purpose of this one goes far beyond removing the parts that are no longer used in V2. I'm changing the title of this ticket right away to the more general title "V2 Code Cleanup". I think the goals of this ticket are:
Let me know if I forget something. |
After a big effort, I think we can now close this ticket, the cleanup is now done, as far as possible ... Special attention has been paid to the docstring. Most of it is up to date. I admit I put ""Blabla"" a few times by laziness or lack of time... We can always do a search on Blabla and fix it later, when we have some time... All UTs work correctly now and the codes match them with a minimum of exceptions (for example, for Flake8, only C901 and W503 which are almost impossible to meet). There is only one issue with isort that I could not fix. One can, while waiting to solve this problem, live with it by running isort locally and commenting in .pre-commit-config.yaml file before pushing to GitHub. |
We have started to comment on them (by chance from working on something else 794fe57) but they should be deleted properly. It's not a priority, but it should be done one of these days!
The text was updated successfully, but these errors were encountered: