Support empty arrays in dynamic in - fixes #417

porsager · Jul 22, 2022 · 85bca49 · 85bca49
1 parent eeecc06
commit 85bca49
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/src/types.js b/src/types.js
@@ -153,7 +153,10 @@ function select(first, rest, parameters, types, options) {
 
 const builders = Object.entries({
   values,
-  in: values,
+  in: (...xs) => {
+    const x = values(...xs)
+    return x === '()' ? '(null)' : x
+  },
   select,
   as: select,
   returning: select,

diff --git a/tests/index.js b/tests/index.js
@@ -929,6 +929,16 @@ t('dynamic insert pluck', async() => {
   return [null, (await sql`insert into test ${ sql(x, 'a') } returning *`)[0].b, await sql`drop table test`]
 })
 
+t('dynamic in with empty array', async() => {
+  await sql`create table test (a int)`
+  await sql`insert into test values (1)`
+  return [
+    (await sql`select * from test where null in ${ sql([]) }`).count,
+    0,
+    await sql`drop table test`
+  ]
+})
+
 t('dynamic in after insert', async() => {
   await sql`create table test (a int, b text)`
   const [{ x }] = await sql`
@@ -2218,4 +2228,4 @@ t('Insert array with undefined transform', async() => {
     (await sql`select x from test`)[0].x[0],
     await sql`drop table test`
   ]
-})
+})