Catch connection errors using transactions (begin) - fixes #162

porsager · Mar 23, 2021 · fff6640 · fff6640
1 parent 16bc7db
commit fff6640
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/lib/index.js b/lib/index.js
@@ -142,7 +142,7 @@ function Postgres(a, b) {
             ? 'rollback'
             : 'rollback to ' + savepoint
         )
-        .then(() => reject(err))
+        .then(() => reject(err), reject)
       })
       .then(begin && (() => {
         connections.push(connection)

diff --git a/tests/index.js b/tests/index.js
@@ -750,6 +750,25 @@ t('little bobby tables', async() => {
   ]
 })
 
+t('Connection errors are caught using begin()', {
+  timeout: 20000
+}, async() => {
+  let error
+  try {
+    const sql = postgres({ host: 'wat' })
+
+    await sql.begin(async(sql) => {
+      await sql`insert into test (label, value) values (${1}, ${2})`
+    })
+
+    await sql.end()
+  } catch (err) {
+    error = err
+  }
+
+  return ['ENOTFOUND', error.code]
+})
+
 t('dynamic column name', async() => {
   return ['!not_valid', Object.keys((await sql`select 1 as ${ sql('!not_valid') }`)[0])[0]]
 })