Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some undefined types issues #447

Merged
merged 3 commits into from
Aug 9, 2022
Merged

Fix some undefined types issues #447

merged 3 commits into from
Aug 9, 2022

Conversation

Minigugus
Copy link
Contributor

@Minigugus Minigugus commented Jul 30, 2022 •
edited

Fixes #407 undefined were missing on optional properties
Fixes #446 undefined were not allowed in insert helper calls

Also, it seems that sql fragments were not allowed by types (it's strange that no user have issues with this bug yet 🤔 but it's fixed now anyway)

I don't know if I should run the build script for transpilation; some commits where not transpiled, poluting the PR if I commit these changes 😕

@porsager porsager merged commit 097d272 into porsager:master Aug 9, 2022
porsager pushed a commit that referenced this pull request Feb 1, 2023
@Minigugus @porsager
Fix some undefined types issues (#447)
db698a1 
* Support `exactOptionalPropertyTypes` - fixes #407

* Allow `undefined` properties with insert helper (types only) - fixes #446

* Allow sql fragements as tagged template parameters (types only)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError: doesn't work if exactOptionalPropertyTypes:true in tsconfig.json
2 participants
@Minigugus @porsager