Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter "url" must be a string, not a boolean #15

Closed
barneycarroll opened this issue Feb 19, 2017 · 2 comments
Closed

Parameter "url" must be a string, not a boolean #15

barneycarroll opened this issue Feb 19, 2017 · 2 comments

Comments

@barneycarroll
Copy link
Contributor

If config.main isn't an HTTP URI, config.external is set to false. This screws things up when serve.js unconditionally tries to parse it as a URI and extract the host. This is odd, since earlier parts of serve.js seem to expect config.external to be a boolean or at least falsey.

Starting wright...
Error: TypeError: Parameter "url" must be a string, not boolean
    at Url.parse (url.js:87:11)
    at Object.urlParse [as parse] (url.js:81:5)
    at Promise (C:\Program Files\Nodist\bin\node_modules\wright\lib\serve.js:40:39)
    at module.exports.start (C:\Program Files\Nodist\bin\node_modules\wright\lib\serve.js:30:10)
@porsager
Copy link
Owner

Hi Barney. Thanks a lot, for the heads up. I really should get some tests set up.

@barneycarroll
Copy link
Contributor Author

Haha yeah I have that problem too. So hard to develop tooling that's still evolving and make rational tests alongside, a lot of the time it feels like you're overformalising self-evident stuff that's liable to change any minute anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants