-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for internationalization (i18n) #3015
Milestone
Comments
6 tasks
michaelworm
added a commit
that referenced
this issue
May 31, 2024
michaelworm
added a commit
that referenced
this issue
Jun 3, 2024
michaelworm
added a commit
that referenced
this issue
Jun 3, 2024
michaelworm
added a commit
that referenced
this issue
Jun 7, 2024
michaelworm
added a commit
that referenced
this issue
Jun 7, 2024
michaelworm
added a commit
that referenced
this issue
Jun 7, 2024
michaelworm
added a commit
that referenced
this issue
Jun 10, 2024
michaelworm
added a commit
that referenced
this issue
Jul 2, 2024
michaelworm
added a commit
that referenced
this issue
Jul 4, 2024
The following is already done:
|
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Scope
With the results of #2615 we want to unify
intl
andaria
props in order to allow customization ofaria-label
attributes.Therefore we do the following
intl
prop gets deprecatedaria
props since currently all values affect screen readers onlyp-pagination
PorscheDesignSystemModule
andPorscheDesignSystemProvider
bycomponents
prop/option for defaultaria
configuration (see [SPIKE]: Support for internationalization (i18n) (Issue/2615) #3004 for a draft) -> maybe we should limit the aria definition on module/provider level byaria-label
only.Notes
intl
propp-carousel
(Override the default wordings that are used for aria-labels on the next/prev buttons and pagination.)p-pagination
(Override the default wordings that are used for aria-labels on the next/prev and page buttons.)aria
propp-button
p-button-pure
p-button-tile
p-carousel
p-crest
p-flyout
p-flyout-navigation
p-icon
p-link
p-link-pure
p-link-tile
p-marque
p-modal
p-pagination
p-popover
p-scroller
p-spinner
p-tag-dismissible
p-wordmark
p-button
that have a nestedp-spinner
with a hard codedaria={{ 'aria-label': 'Loading state' }}
which currently is not extractedloading-message.tsx
for wordingshideLabel
prop orsr-only
classAcceptance criteria
aria
prop is extended where needed to support multiple DOM related aria definitionsintl
prop is deprecated (including validation and documentation) for all components and mapped to the new extendedaria
approach (to not have a breaking change)aria
configuration (limited to wordings) can be provided atPorscheDesignSystemModule
andPorscheDesignSystemProvider
but should still be overwriteable on component level (like it's the case for e.g.theme
)aria
prop on component level orPorscheDesignSystemModule
andPorscheDesignSystemProvider
Subtasks
The text was updated successfully, but these errors were encountered: