Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A11y Test in Storefront is not executed for dark theme (Issue/3099) #3350

Merged
merged 27 commits into from
Jul 1, 2024
Merged

A11y Test in Storefront is not executed for dark theme (Issue/3099) #3350

merged 27 commits into from
Jul 1, 2024

Conversation

o-hook
Copy link
Contributor

@o-hook o-hook commented Jun 19, 2024 •
edited
Loading

Pull Request Checklist

References

Scope

Short description of the pull request scope

Resolved Issue

Resolves #3099

o-hook added 16 commits June 17, 2024 13:48
@o-hook
test(storefront): enhance axe-core test for dark mode | oh | #3099
d059cd2
@o-hook
Merge branch 'main' into issue/3099
b05ff12
@o-hook
test(storefront): fix and split a11y test | oh | #3099
ad8609c
@o-hook
test(workflow): adapt shardIndex | oh | #3099
d728a99
@o-hook
test(storefront): fix package script | oh | #3099
35cd2e4
@o-hook
test(docker): adapt docker script | oh | #3099
60269f8
@o-hook
test(docker): adapt docker script | oh | #3099
2a9566b
@o-hook
ci: update docker image | oh / hj | #3099
1ad1468
@o-hook
ci: adapt tag of docker file | oh / hj | #3099
abf883b
@o-hook
test(storefront): refactored axe-core test and added test for dark sc…
f6c6e84 
…heme | oh | #3099
@o-hook
test(storefront): reduce tests to minimum setup | oh| #3099
e869b75
@o-hook
Merge branch 'main' into issue/3099
a017a42
@o-hook
core(storefront): update axe-core-npm | oh | #3099
c2c3ebe
@o-hook
fix(storefront): fix color contrast issues | oh | #3099
6375fca
@o-hook
test(storefront): update vrt fixture | oh | #3099
92ae68b
@o-hook
test(storefront): removed comment | oh | #3099
7d9f05b
@o-hook o-hook marked this pull request as ready for review June 19, 2024 11:31
@o-hook o-hook requested a review from henrijoss June 19, 2024 11:31
o-hook and others added 4 commits June 24, 2024 09:20
@o-hook o-hook requested a review from henrijoss June 24, 2024 09:30
henrijoss
henrijoss previously approved these changes Jun 24, 2024
View reviewed changes
@o-hook
Merge branch 'main' into issue/3099
a1963cd 
# Conflicts:
#	.github/actions/docker-run-playwright/action.yml
#	.github/workflows/build-and-test.yml
#	.github/workflows/deploy-and-release.yml
#	.github/workflows/ort.yml
#	docker-compose.yml
#	docker/build-and-push-docker-image.sh
@o-hook o-hook requested a review from henrijoss June 27, 2024 07:08
@o-hook o-hook requested a review from henrijoss July 1, 2024 07:31
@o-hook @henrijoss
Update packages/storefront/tests/a11y/specs/accessibility.a11y.ts
26f6bfb 
Co-authored-by: henrijoss <44018513+henrijoss@users.noreply.github.com>
@o-hook o-hook requested a review from henrijoss July 1, 2024 08:59
@o-hook o-hook merged commit e6b5fde into main Jul 1, 2024
48 checks passed
@o-hook o-hook deleted the issue/3099 branch July 1, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henrijoss henrijoss henrijoss approved these changes

@stephanschroeter stephanschroeter Awaiting requested review from stephanschroeter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A11y Test in Storefront is not executed for dark theme on component example level
2 participants
@o-hook @henrijoss