Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
using
dependency:list
to fetch dependencies/licenses can be quite inefficient, this PR adds and option to re-use an already existinglicenses.xml
file as generated bylicenses-maven-plugin:download-licenses
.I am aware it might have been better to open an issue first, but it has been some time since I wrote non-CI code so I did it also for fun. :)
Points to be clarified:
license-maven-plugin
-- I also considered copying the files in verbartim (it's only three files), but I stuck with the dependency with exclusionsdependency:list
approach, I am open to changes, for the use-case I have in mind the current state does the job. :)