Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to reuse licenses.xml #320

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

criztovyl
Copy link
Contributor

Hi there,

using dependency:list to fetch dependencies/licenses can be quite inefficient, this PR adds and option to re-use an already existing licenses.xml file as generated by licenses-maven-plugin:download-licenses.

I am aware it might have been better to open an issue first, but it has been some time since I wrote non-CI code so I did it also for fun. :)

Points to be clarified:

  • dependency on license-maven-plugin -- I also considered copying the files in verbartim (it's only three files), but I stuck with the dependency with exclusions
  • I hid it behind a feature flag and the feature flag at the same time disables the dependency:list approach, I am open to changes, for the use-case I have in mind the current state does the job. :)
  • (unit-)tests

Signed-off-by: Christoph "criztovyl" Schulz <ch.schulz@joinout.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant