Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Framework] Introduce async iterators streamer util function #526

Merged
merged 9 commits into from
Apr 17, 2024

Conversation

Tankilevitch
Copy link
Contributor

Description

What - Introduce async iterators streamer util function
Why - Re-usable function that allows to iterator over multiple APIs concurrently
How -

Type of change

Please leave one option from the following and delete the rest:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • New Integration (non-breaking change which adds a new integration)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Non-breaking change (fix of existing functionality that will not change current behavior)
  • Documentation (added/updated documentation)

Screenshots

Include screenshots from your environment showing how the resources of the integration will look.

API Documentation

Provide links to the API documentation used for this integration.

pyproject.toml Outdated Show resolved Hide resolved
@github-actions github-actions bot added the framework A change in the ocean framework files label Apr 12, 2024
@github-actions github-actions bot added size/L and removed size/M labels Apr 12, 2024
Copy link
Collaborator

@yairsimantov20 yairsimantov20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌊 amazing addition
Maybr we should start using it in the corr

port_ocean/utils/async_iterators.py Outdated Show resolved Hide resolved
port_ocean/utils/async_iterators.py Show resolved Hide resolved
pyproject.toml Outdated
@@ -56,6 +56,7 @@ click = { version = "^8.1.3", optional = true }
rich = { version = "^13.4.1", optional = true }
cookiecutter = { version = "^2.1.1", optional = true }
jinja2-time = { version = "^0.2.0", optional = true }
aiostream = "^0.5.2"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move it above the cli deps

@Tankilevitch Tankilevitch merged commit 41544ec into main Apr 17, 2024
4 checks passed
@Tankilevitch Tankilevitch deleted the introduce-async-iterators branch April 17, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework A change in the ocean framework files size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants