[Framework] Caching port app config #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tankilevitch
requested changes
May 15, 2024
yairsimantov20
approved these changes
May 16, 2024
|
|
||
|
|
||
| class PortAppConfigCache: | ||
| _port_app_config: PortAppConfig |
There was a problem hiding this comment.
Suggested change
| _port_app_config: PortAppConfig | |
| _port_app_config: PortAppConfig | None |
CHANGELOG.md
Outdated
|
|
||
| ### Improvements | ||
|
|
||
| - Added caching to port-app-config.yml retrieval from port api |
There was a problem hiding this comment.
specify that itll only be used for live events
yairsimantov20
approved these changes
May 16, 2024
|
|
||
| ### Improvements | ||
|
|
||
| - Added caching to port-app-config.yml retrieval from port api (only for live events) |
There was a problem hiding this comment.
Suggested change
| - Added caching to port-app-config.yml retrieval from port api (only for live events) | |
| - Added caching to port-app-config.yml retrieval from port api (Applied only for non resync integration events like live events) |
Tankilevitch
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What - Caching port app config
Why - To reduce requests to port-api
How - Save the config in a class attribute and update if previous config request was more than a minute ago
Saves average of 1 second in response time for real time events when overloaded
Type of change
Please leave one option from the following and delete the rest:
Screenshots
Include screenshots from your environment showing how the resources of the integration will look.
API Documentation
Provide links to the API documentation used for this integration.