-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PORT-7441 Add scheduled gitlab mode to incident mgt, code security, cloud cost and more #1235
PORT-7441 Add scheduled gitlab mode to incident mgt, code security, cloud cost and more #1235
Conversation
- PagerDuty - ServiceNow - FireHydrant - Opsgenie
This pull request is automatically being deployed by Amplify Hosting (learn more). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some comments
<br/> | ||
|
||
|
||
Here is an example for `argocd-integration.yml` pipeline file: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't the file name be gitlab-ci.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, it should be. thank you for picking this up
|
||
|
||
Here is an example for `kubecost-integration.yml` pipeline file: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't it be gitlab-ci.yml?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
applies to all files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resolved
| `OCEAN__INTEGRATION__IDENTIFIER` | Change the identifier to describe your integration, if not set will use the default one | ❌ | | ||
| `OCEAN__PORT__CLIENT_ID` | Your port client id | ✅ | | ||
| `OCEAN__PORT__CLIENT_SECRET` | Your port client secret | ✅ | | ||
| `OCEAN__PORT__BASE_URL` | Your port base url, relevant only if not using the default port app | ❌ | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you remove port base url from all examples?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed it from all integrations in this PR. I will remove it also from this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I also be removing it from the helm parameters ie.
`--set port.baseUrl="https://api.getport.io" \`
I noticed some integrations have it and others don't
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes let's also remove it from the helm params
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi. I have removed this now
3041fa4
to
876b168
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Integrations (1):
Integrations (2):
Integrations (3):
Integrations (4):
Updated docs pages
Please also include the path for the updated docs
Integrations (1):
Integrations (2):
Integrations (3):
Integrations (4):