Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PORT-7441 Add scheduled gitlab mode to incident mgt, code security, cloud cost and more #1235

Merged
merged 9 commits into from
May 27, 2024

Conversation

phalbert
Copy link
Contributor

@phalbert phalbert commented May 21, 2024

Description

Integrations (1):

  • PagerDuty
  • ServiceNow
  • FireHydrant
  • Opsgenie

Integrations (2):

  • SonarQube
  • Synk
  • Wiz

Integrations (3):

  • Kubecost
  • Opencost

Integrations (4):

  • Kafka
  • ArgoCD

Updated docs pages

Please also include the path for the updated docs
Integrations (1):

  • docs/build-your-software-catalog/sync-data-to-catalog/incident-management/firehydrant.md
  • docs/build-your-software-catalog/sync-data-to-catalog/incident-management/opsgenie.md
  • docs/build-your-software-catalog/sync-data-to-catalog/incident-management/pagerduty.md
  • docs/build-your-software-catalog/sync-data-to-catalog/incident-management/servicenow.md

Integrations (2):

  • docs/build-your-software-catalog/sync-data-to-catalog/code-quality-security/snyk/snyk.md
  • docs/build-your-software-catalog/sync-data-to-catalog/code-quality-security/sonarqube/sonarqube.md
  • docs/build-your-software-catalog/sync-data-to-catalog/code-quality-security/wiz.md

Integrations (3):

  • docs/build-your-software-catalog/sync-data-to-catalog/cloud-cost/kubecost.md
  • docs/build-your-software-catalog/sync-data-to-catalog/cloud-cost/opencost.md

Integrations (4):

  • docs/build-your-software-catalog/sync-data-to-catalog/event-processing/kafka.md
  • docs/build-your-software-catalog/sync-data-to-catalog/argocd/argocd.md

- PagerDuty
- ServiceNow
- FireHydrant
- Opsgenie
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-1235.d2ngvl90zqbob8.amplifyapp.com

@phalbert phalbert changed the title PORT-7441 Add scheduled gitlab mode to incident mgt PORT-7441 Add scheduled gitlab mode to incident mgt, code security, cloud cost and more May 21, 2024
Copy link
Contributor

@yairsimantov20 yairsimantov20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments

<br/>


Here is an example for `argocd-integration.yml` pipeline file:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't the file name be gitlab-ci.yml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it should be. thank you for picking this up



Here is an example for `kubecost-integration.yml` pipeline file:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't it be gitlab-ci.yml?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

applies to all files

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved

| `OCEAN__INTEGRATION__IDENTIFIER` | Change the identifier to describe your integration, if not set will use the default one | ❌ |
| `OCEAN__PORT__CLIENT_ID` | Your port client id | ✅ |
| `OCEAN__PORT__CLIENT_SECRET` | Your port client secret | ✅ |
| `OCEAN__PORT__BASE_URL` | Your port base url, relevant only if not using the default port app | ❌ |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you remove port base url from all examples?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed it from all integrations in this PR. I will remove it also from this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I also be removing it from the helm parameters ie.

`--set port.baseUrl="https://api.getport.io"  \`

I noticed some integrations have it and others don't

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes let's also remove it from the helm params

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. I have removed this now

@phalbert phalbert force-pushed the PORT-7441-add-gitlab-scheduled-mode branch from 3041fa4 to 876b168 Compare May 27, 2024 15:10
Copy link
Member

@MPTG94 MPTG94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MPTG94 MPTG94 dismissed yairsimantov20’s stale review May 27, 2024 16:19

Requested changes were made

@MPTG94 MPTG94 merged commit ad559c6 into port-labs:main May 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants