Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PORT-7361 | Mini guide to connect Github repository with SonarQube project #1238

Merged
merged 8 commits into from
Jun 20, 2024

Conversation

lordsarcastic
Copy link
Contributor

Description

This mini guide is on the other direction of connect SonarQube project to service but does the connection on the GitHub side

Added docs pages

Please also include the path for the added docs

  • Connect GitHub repository with SonarQube project (docs/build-your-software-catalog/sync-data-to-catalog/git/github/guides/connect-github-repository-with-sonarqube-project.md)

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-1238.d2ngvl90zqbob8.amplifyapp.com

Copy link
Contributor

@yairsimantov20 yairsimantov20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@yairsimantov20 yairsimantov20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌊 Tech stuff looks good

@@ -0,0 +1,107 @@
import PortTooltip from "/src/components/tooltip/tooltip.jsx"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lordsarcastic The new "guides" folder has a lowercase "g" in the sidebar, it should be "Guides". To resolve this, please add a _category_.json file to the folder, see other folders for examples.

@@ -0,0 +1,107 @@
import PortTooltip from "/src/components/tooltip/tooltip.jsx"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lordsarcastic Most of the images are very big, need to make them smaller. Use the "width" prop to do this, for example:
<img src='/img/build-your-software-catalog/sync-data-to-catalog/github/addNewRelationToService.png' border='1px' width=50% />

Play around with the width until it looks good on the page

@hadar-co hadar-co merged commit a301e22 into main Jun 20, 2024
2 checks passed
@hadar-co hadar-co deleted the port-7361 branch June 20, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants