New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Melhor instalação de dependências #449

Merged
merged 2 commits into from Oct 11, 2018

Conversation

Projects
None yet
4 participants
@edersoares
Member

edersoares commented Oct 11, 2018

Seguindo os passos do readme, sempre que o comando para rodar as migrations é executado, o Composer ainda não terminou de instalar as dependências e quem está rodando os comandos não consegue identificar o status atual da instalação devido o log não ser exibido.

Este pull request remove o serviço composer do docker-compose.yml e adiciona ao readme o comando para ser executado manualmente na sequencia correta.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Oct 11, 2018

Pull Request Test Coverage Report for Build 153

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.771%

Totals Coverage Status
Change from base Build 148: 0.0%
Covered Lines: 1769
Relevant Lines: 229545

💛 - Coveralls

coveralls commented Oct 11, 2018

Pull Request Test Coverage Report for Build 153

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.771%

Totals Coverage Status
Change from base Build 148: 0.0%
Covered Lines: 1769
Relevant Lines: 229545

💛 - Coveralls
@eberfreitas

Não entendi a alteração. O serviço não estava funcionando como esperado?

[Edit] Agora li a descrição do PR. Entendi a motivação :)

@edersoares edersoares merged commit 98fc3cb into master Oct 11, 2018

2 checks passed

Scrutinizer Analysis: 2 new issues – Tests: passed
Details
coverage/coveralls Coverage remained the same at 0.771%
Details

@edersoares edersoares deleted the composer-install branch Oct 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment