Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: package.json conditional exports: default condition should be the last one #77

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

gesi
Copy link
Contributor

@gesi gesi commented Dec 5, 2023

During a dependency upgrade I was running into an error: Module not found: Error: Default condition should be last one.
After a bit of digging it seems that the source is this package and how the conditional exports are set up. The documentation says this about conditional exports (emhasis mine):

"default": the generic fallback that always matches. Can be a CommonJS or ES module file. This condition should always come last.

Copy link

vercel bot commented Dec 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
svelte-portabletext ❌ Failed (Inspect) Dec 5, 2023 0:18am

@evenwestvang
Copy link

Thank you for this - we'll review

@snorrees snorrees merged commit 97ced63 into portabletext:main Dec 14, 2023
9 of 10 checks passed
@snorrees
Copy link

Thanks! Released in v2.1.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants