Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

!("markDefs" in node) does not account for markDefs: undefined #24

Closed
spacedawwwg opened this issue Aug 6, 2023 · 0 comments · Fixed by #25
Closed

!("markDefs" in node) does not account for markDefs: undefined #24

spacedawwwg opened this issue Aug 6, 2023 · 0 comments · Fixed by #25

Comments

@spacedawwwg
Copy link
Contributor

spacedawwwg commented Aug 6, 2023 •
edited 

!("markDefs" in node)

This does not account for markDefs: undefined which is being returned from Sanity in query (but not output when I wrote to a JSON file)

changing this to simply !node.markDefs fixes the issue theisel/astro-portabletext#60
@spacedawwwg spacedawwwg changed the title !("markDefs" in node) This does not account for markDefs: undefined !("markDefs" in node) does not account for markDefs: undefined Aug 6, 2023
spacedawwwg added a commit to spacedawwwg/toolkit that referenced this issue Aug 6, 2023
@spacedawwwg
fix: isPortableTextBlock not accounting for markDefs: undefined
4e3cb5b 
Fixes portabletext#24
This was referenced Aug 6, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@spacedawwwg