Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Absolute URL's for favicons etc... #1342

Closed
zcalusic opened this issue Oct 29, 2017 · 4 comments
Closed

Absolute URL's for favicons etc... #1342

zcalusic opened this issue Oct 29, 2017 · 4 comments
Labels
good first issue kind/enhancement Applied to Feature Requests
Milestone
1.15.1

Comments

@zcalusic
Copy link

zcalusic commented Oct 29, 2017 •
edited

Description

I noticed that /ico/... URL's are absolute. This means that going through nginx proxy, and using the recommended 2 rules, which cover only /portainer/ namespace, those icons are not found.

Of course, it could be avoided by adding third rule and stealing /ico/ namespace, too. But, the better solution would be just to make those URL's relative.

Steps to reproduce the issue:

  1. Run portainer behind nginx proxy using recommended rules from the FAQ.
  2. Watch how portainer is using host default favicon, instead of portainer one.

Technical details:

  • Portainer version: 1.15.0
  • Target Docker version: 17.10.0
  • Platform: linux
  • Browser: firefox 56.0.2
@deviantony
Copy link
Member

Hmm, would that be a reverse proxy configuration issue? We might need to update it.

@zcalusic
Copy link
Author

Is there any problem making those links relative? It would be the best fix.

@deviantony
Copy link
Member

Ah I see, I believe this should not be complicated to change.

@eine eine mentioned this issue Oct 30, 2017
Merged
@deviantony
Copy link
Member

Closed via #1343

@deviantony deviantony added this to the 1.15.x milestone Oct 30, 2017
@deviantony deviantony modified the milestones: 1.15.x, 1.15.1 Nov 8, 2017
xAt0mZ added a commit that referenced this issue Aug 25, 2022
@xAt0mZ
fix(edge-jobs): HTTP 404 on file upload (#1342)
679de80 
* fix(edge-jobs): HTTP 404 on file upload

* fix(edge-jobs): state 'edge job' in message on edge job removal instead of 'stack'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue kind/enhancement Applied to Feature Requests
Projects
None yet
Milestone
1.15.1
Development

No branches or pull requests
2 participants
@deviantony @zcalusic