Non-working authenticated registries prevent stack operations that don't involve that registry

[nbaum]

Description

If an authenticating registry is configured which cannot be used at the time that a stack is deployed or updated, the appropriate changes to Docker's state are not made, and an error message appears relating to whatever it is that is stopping the registry working.

This happens whether or not deploying the stack would need to access the registry. The compose file is created or updated, but no containers, networks, or volumes are created.

Invalid YAML in the compose file does not produce an error message, so presumably whatever is checking the registries is doing so quite early in the process.

Steps to reproduce the issue:

1. Add a registry - with a username and password - which will not work. e.g. Bad domain name; no registry running on it; credentials invalid.
2. Deploy or update any stack.

Instead of working, an error pops up, according to whatever is wrong with the registry.

Technical details:

• Portainer version: 0.16.1
• Target Docker version (the host/cluster you manage): 17.06.0-ce
• Platform (windows/linux): Linux
• Command used to start Portainer (docker run -p 9000:9000 portainer/portainer): I start it via docker compose - docker-compose.yml
• Target Swarm version (if applicable): I don't know how to determine this, sorry.
• Browser: Chrome 61

[deviantony]

Right, this is due to the fact that we use the embedded Docker binary to deploy stacks. A work-around this might be to simply ignore any docker login errors before deploying a stack.

[deviantony]

Hi @nbaum

Could you give a try to portainer/portainer:pr1635 and tell me if it solves your issue?

[nbaum]

That fixes the issue for me. 👍