Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Health checks not updated when using duplicate/edit #3321

Closed
Enrico204 opened this issue Oct 31, 2019 · 3 comments
Closed

Health checks not updated when using duplicate/edit #3321

Enrico204 opened this issue Oct 31, 2019 · 3 comments

Comments

@Enrico204
Copy link

Bug description
Re-creating (or editing) a container won't update healthchecks if they specification changes inside the image specification.

Expected behavior
On container re-creating/edit, health checks settings (such as commands, interval, etc) are updated if they're updated in the container image.

Steps to reproduce the issue:

  1. Create a container image with an healthcheck (type CMD-SHELL)
  2. Run a container from that image
  3. Update the image, changing healthchecks parameters (I tried changing CMD-SHELL in CMD)
  4. Re-create (or edit) the container. The new container will use old configurations for healthchecks.

Technical details:

  • Portainer version: 1.22.1
  • Docker version (managed by Portainer): 19.03.1
  • Platform (windows/linux): Debian Linux 9
  • Command used to start Portainer: docker run -d -p 9000:9000 -v /var/run/docker.sock:/var/run/docker.sock -v portainer_data:/data portainer/portainer
  • Browser: Firefox

Additional context
Healthchecks are created correctly if no healthchecks were specified in the previous image definition.

@ghost ghost added this to Need triage in Bug triage via automation Oct 31, 2019
@ghost
Copy link

ghost commented Apr 7, 2020

Confirmed on 1.23.2

@ghost ghost changed the title Health checks not updated when the manifest changes Health checks not updated when using duplicate/edit Apr 7, 2020
@ghost ghost added the severity/medium label Apr 24, 2020
@ghost
Copy link

ghost commented Jun 26, 2020

Reproduced on development branch. Closing as this will be addressed via #3964 in v2.0

@ghost ghost closed this as completed Jun 26, 2020
Bug triage automation moved this from Need triage to Fixed Jun 26, 2020
@ghost
Copy link

ghost commented Jul 20, 2020

This will actually be fixed via the introduction of healthcheck functionality via container create/duplicate in #3572

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

1 participant