Auto suggest for images on multinode swarm suggests the same image multiple times

[ghost]

Bug description
Auto suggest for images on multinode swarm suggests the same image multiple times

Expected behavior
Auto suggest should only suggest an image once, even if the same image is present on different nodes

Steps to reproduce the issue:

1. Pull same image on multiple nodes
2. Get multiple auto suggestions

Technical details:

• Portainer version: develop
• Docker version (managed by Portainer): 19.03
• Platform (windows/linux): linux
• Command used to start Portainer (docker run -p 9000:9000 portainer/portainer): portainer agent stack
• Browser: firefox

[xAt0mZ]

Images are already filtered to be unique across the swarm. The problem we have here is that the ID of images (so the version for each node) is not necessary the same.

As we only display the tag we are seeing duplicates, but they are not.

I can push a fix where all tags are always unique regardless of the source image ID and the origin of the image.

Tho it can lead to weird issues:

• deploying a service with nginx:latest with different images on every node can lead to an unknown behaviour (can't recall if we are making a force pull in this situation)
• in a multinode env, creating a container without force pull can lead to images not existing on the target node : we may need to add an additional filter to list only the images existing on the target node

[deviantony]

@xAt0mZ yes, please filter on unique image names.