Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access control management via labels not fault tolerant #3547

Closed
m-a-v opened this issue Feb 4, 2020 · 3 comments · Fixed by #4823
Closed

Access control management via labels not fault tolerant #3547

m-a-v opened this issue Feb 4, 2020 · 3 comments · Fixed by #4823

Comments

@m-a-v
Copy link

m-a-v commented Feb 4, 2020

Bug description
If user names are entered multiple times or with spaces in the docker compose file, the access rights are not set correctly.

From #3337:
There seem to be problems with double entries. E.g.
- "io.portainer.accesscontrol.users=bob,adam,bob"

This changes the ownership of the group to restricted. But neither bob nor adam are listed.

Probably, the strings should be trimmed. Otherwise adam will not have access to the resource.
- "io.portainer.accesscontrol.users=bob, adam"

Expected behavior
Both users adam and bob should get access.

@ghost ghost changed the title access control management in Docker not fault tolerant Access control management via labels not fault tolerant Apr 6, 2020
@ghost
Copy link

ghost commented Apr 6, 2020

Seems this is also not tolerant of spaces as "io.portainer.accesscontrol.users=bob, adam" only restricts to bob

@m-a-v
Copy link
Author

m-a-v commented Apr 6, 2020

Seems this is also not tolerant of spaces as "io.portainer.accesscontrol.users=bob, adam" only restricts to bob

See above. I've already mentioned this ... (the strings should be trimmed)

@ghost
Copy link

ghost commented Apr 20, 2020

Reproduced on 1.23.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants