feat(stack-details): Add support to pull latest stack configuration before st… #1793
Conversation
|
Hey @rahulruikar ! Sorry for the delay. FYI, I'm not able to build the backend: Whilst this implementation looks good, I'm not really keen to store unencrypted git passwords in the Portainer database... (sorry I sent you on this direction in #1753 (comment)...) I'm thinking that #1752 should be the priority at the moment, and we'll then be able to enable the update button using ssh key auth. I'll keep this PR open as a reference for future work but marked as pending until #1752 is solved. |
|
Ok no problem..I will work on #1752 and then we will see about this PR
On Thu, 26 Apr 2018 at 12:14 am, Anthony Lapenna ***@***.***> wrote:
Hey @rahulruikar <https://github.com/rahulruikar> ! Sorry for the delay.
FYI, I'm not able to build the backend:
# github.com/portainer/portainer/git
../../../../../go/src/github.com/portainer/portainer/git/git.go:47: unknown field 'Username' in struct literal of type "gopkg.in/src-d/go-git.v4/plumbing/transport/http".BasicAuth
../../../../../go/src/github.com/portainer/portainer/git/git.go:48: unknown field 'Password' in struct literal of type "gopkg.in/src-d/go-git.v4/plumbing/transport/http".BasicAuth
Whilst this implementation looks good, I'm not really keen to store
unencrypted git passwords in the Portainer database... (sorry I sent you on
this direction in #1753 (comment)
<#1753 (comment)>
...)
I'm thinking that #1752
<#1752> should be the
priority at the moment, and we'll then be able to enable the update button
using ssh key auth.
I'll keep this PR open as a reference for future work but marked as
pending until #1752 <#1752>
is solved.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1793 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHXNPbdsK7-my_FjddJfLlFGscd0TtiKks5tsIS6gaJpZM4TKNu_>
.
--
Sent from Gmail Mobile
|
|
It is possible to help in any way? I would like to have this feature. |
|
@farodin91 My opinion on this is that we need #1752 first as we're not keen to persist git authentication credentials into Portainer. Once #1752 is implemented, we'll be able to tackle this one. |
|
Closing this one as it's outdated and we'll need to review the design after #1752 is implemented. |
Fix #1753