feat(containers): added z-flag support for bind mounts in container creation

[Trudels]

Hey Anthony,

Please let me know about the status of the PR.

Greets & Have a nice day
Sebastian

[G07cha]

Is there any issue already to which this PR is related to?

[deviantony]

Yes there is: #853

[G07cha]

Alright, so if this feature works only for SELinux maybe we can check if OS is SELinux using SystemInfo call before displaying additional UI elements(just to avoid inputs that is not going to affect anything).

[deviantony]

@G07cha these options help working around issues when using Docker with SELinux enabled but I don't think that they are reserved to these kind of environments.

[G07cha]

But is it affects anything in other environments? If it's not I don't see a point of having it for places where it doesn't affect anything.

[Trudels]

@G07cha the :z flag enables to inherit permissions including selinux labels (most common problem occurance in combination with the z flag)
i think the answer to this post (https://stackoverflow.com/questions/34031397/running-docker-on-ubuntu-mounted-host-volume-is-not-writable-from-container) is a good explanation of the z flag, maybe the description of the switch should be more generic?

& is there any need of adding the :Z flag too?

[deviantony]

I believe that we should support both. It's just a matter of UX, for each volume we should be able to specify rw, ro, z, or Z.

[G07cha]

If it's effective in most of OS-es then it's good to me! Thanks for the explanation, @Trudels!

[Trudels]

@deviantony actually you can create volumes with ro + z

[deviantony]

@Trudels you're right, removed my comment.

From Docker docs:

-v, --volume=[host-src:]container-dest[:<options>]: Bind mount a volume.
The comma-delimited `options` are [rw|ro], [z|Z],
[[r]shared|[r]slave|[r]private], and [nocopy].
The 'host-src' is an absolute path or a name value.

I'll try to have a look at the proposed UX in this PR soon.

[Trudels]

alright let me know if you know how i should implement it, or are you taking over? i don't mind..

Greetings

[deviantony]

Feel free to propose something to support both z & Z. I'm a bit busy on other topics right now.

[Trudels]

alright i'll think about something...

Greets