Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display stack and host info when applicable #2331

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

briankabiro
Copy link
Contributor

@briankabiro briankabiro commented Oct 4, 2018

What does this PR do?

@deviantony deviantony added the status/1-functional-review Indicates that the PR is currently under functional review label Oct 4, 2018
@deviantony
Copy link
Member

Hey @briankabiro

I don't think this implementation is working, see my screenshots below.

I want to inspect the container new_web_1 which is part of the new stack:

portainer 20

Nothing shows in the container-details:

portainer 21

Note that this is the same for the host info. FYI, the node name is only available when running Portainer with the agent setup inside a Swarm cluster.

Copy link
Member

@deviantony deviantony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments above.

@deviantony deviantony added the changes-required Waiting for an update of the contributor label Oct 4, 2018
@briankabiro
Copy link
Contributor Author

Hi Tony. I'll take a look at it again and make the necessary changes.

@briankabiro briankabiro force-pushed the feat2120-display-stack-and-host-info branch from 4a61c48 to 7234c95 Compare October 8, 2018 12:18
@briankabiro
Copy link
Contributor Author

Hi @deviantony. I've made the changes and it should be okay now. Let me know if there's any refactoring I'll need to do.

@deviantony deviantony removed the changes-required Waiting for an update of the contributor label Oct 8, 2018
Copy link
Member

@deviantony deviantony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @briankabiro

Sorry for the late update.

When a container is part of a Swarm stack (deployed in a Swarm cluster), the stack is not displayed in the container details:

portainer 2

portainer 3

Also, instead of displaying the container hostname as it is done right now, I believe that the OP of #2120 requested the ability to retrieve the name of the node where the container is running.

portainer 1

This feature is only available when using our agent setup and this information can be retrieved via applicationState.endpoint.mode.agentProxy. You'll then be able to access container.NodeName, example:

https://github.com/portainer/portainer/blob/develop/app/docker/components/datatables/containers-datatable/containersDatatable.html#L237

portainer 4

@deviantony deviantony added the changes-required Waiting for an update of the contributor label Oct 13, 2018
@briankabiro
Copy link
Contributor Author

Thanks, Tony. I'll take a look at it and update.

@deviantony deviantony added this to Pending review in Contributions via automation Oct 24, 2018
@deviantony deviantony moved this from Pending review to Waiting for changes in Contributions Oct 24, 2018
- display the stack and host info on the container-details table
@briankabiro briankabiro force-pushed the feat2120-display-stack-and-host-info branch from 7234c95 to eba50ba Compare November 28, 2018 12:18
@briankabiro
Copy link
Contributor Author

Hey, @deviantony! I've made the requested changes(been a while 😉) - thanks again for the pointers

@deviantony deviantony removed the changes-required Waiting for an update of the contributor label Nov 28, 2018
@deviantony deviantony moved this from Waiting for changes to Functional validation in Contributions Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has conflicts status/1-functional-review Indicates that the PR is currently under functional review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display stack and host info in container details page
3 participants