New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display stack and host info when applicable #2331
base: develop
Are you sure you want to change the base?
Display stack and host info when applicable #2331
Conversation
Hey @briankabiro I don't think this implementation is working, see my screenshots below. I want to inspect the container Nothing shows in the container-details: Note that this is the same for the host info. FYI, the node name is only available when running Portainer with the agent setup inside a Swarm cluster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comments above.
Hi Tony. I'll take a look at it again and make the necessary changes. |
4a61c48
to
7234c95
Compare
Hi @deviantony. I've made the changes and it should be okay now. Let me know if there's any refactoring I'll need to do. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @briankabiro
Sorry for the late update.
When a container is part of a Swarm stack (deployed in a Swarm cluster), the stack is not displayed in the container details:
Also, instead of displaying the container hostname as it is done right now, I believe that the OP of #2120 requested the ability to retrieve the name of the node where the container is running.
This feature is only available when using our agent setup and this information can be retrieved via applicationState.endpoint.mode.agentProxy
. You'll then be able to access container.NodeName
, example:
Thanks, Tony. I'll take a look at it and update. |
- display the stack and host info on the container-details table
7234c95
to
eba50ba
Compare
Hey, @deviantony! I've made the requested changes(been a while 😉) - thanks again for the pointers |
What does this PR do?