Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sorting): added new filter for correct sorting of ip addresses #2334

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

fix(sorting): added new filter for correct sorting of ip addresses #2334

wants to merge 5 commits into from

Conversation

pantegrow
Copy link

@pantegrow pantegrow commented Oct 5, 2018 •
edited by deviantony

  1. Added new function for sorting
  2. Added changes to orderBy filter

Fix #1802

@deviantony deviantony added the status/1-functional-review Indicates that the PR is currently under functional review label Oct 5, 2018
@pantegrow pantegrow mentioned this pull request Oct 10, 2018
Closed
deviantony
deviantony requested changes Oct 13, 2018
View reviewed changes
Copy link
Member

@deviantony deviantony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution and sorry for the late review !

I was just able to test this, but it looks like it's not solving the problem reported in #1802:

portainer

@deviantony deviantony added the changes-required Waiting for an update of the contributor label Oct 13, 2018
@pantegrow
Copy link
Author

Ok, will check tonight. Sorry for delay

@deviantony deviantony added this to Pending review in Contributions via automation Oct 24, 2018
@deviantony deviantony moved this from Pending review to Waiting for changes in Contributions Oct 24, 2018
@mdbraber mdbraber mentioned this pull request Jun 5, 2019
Closed
mdbraber added a commit to mdbraber/portainer that referenced this pull request Jun 5, 2019
@mdbraber
Fix for sorting IPs (portainer#2334 portainer#2995)
f399c5e
@mdbraber mdbraber mentioned this pull request Jun 5, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deviantony deviantony deviantony requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
changes-required Waiting for an update of the contributor has conflicts status/1-functional-review Indicates that the PR is currently under functional review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IP Addresses are not sorted correctly
2 participants
@pantegrow @deviantony