Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(container-details): table word-break ui (#3430) #3442

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(container-details): table word-break ui (#3430) #3442

wants to merge 1 commit into from

Conversation

GuilhermeLibardi
Copy link

@GuilhermeLibardi GuilhermeLibardi commented Dec 5, 2019 •
edited by xAt0mZ

Closes #3430

Table UI looks broken when a container has large env variables.

tela

@GuilhermeLibardi GuilhermeLibardi mentioned this pull request Dec 5, 2019
Closed
@ghost
Copy link

ghost commented Jan 23, 2020 •
edited by ghost

Can you please open a bug report for this and link to it from your PR as I have confirmed there is a bug.
image

ghost
ghost suggested changes Jan 23, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I requested changes, as the change makes the fields go off the page.
image

@xAt0mZ can you think of a better way to fix this?

@xAt0mZ
Copy link
Member

xAt0mZ commented Jan 24, 2020

I think we need to keep break-word: word-break on all td but first one. First <td> will not be breakable but all other <td> will stay breakable, so they will fit inside the page.

chiptus added a commit to chiptus/portainer that referenced this pull request Aug 13, 2023
@chiptus
refactor(settings): migrate ssl panel to react [EE-5506] (portainer#3442
c74dd2b 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
has conflicts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Container details table
2 participants
@GuilhermeLibardi @xAt0mZ