Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

limit only on request failure #3484

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

limit only on request failure #3484

wants to merge 1 commit into from

Conversation

WnP
Copy link

@WnP WnP commented Dec 30, 2019

fix #3092

With this PR the RateLimiter increment only on request failure (>= 400 status code). Maybe it should be renamed according to this, something like FailureRateLimiter.

Let me know your thoughts.

@WnP WnP force-pushed the fix3092-limit-access branch 2 times, most recently from afd31ad to 31bc21d Compare December 30, 2019 15:42
@WnP WnP requested a review from deviantony January 16, 2020 08:24
@deviantony deviantony added this to the 2.1 milestone Jun 24, 2020
@deviantony deviantony removed their request for review October 14, 2020 04:51
@deviantony deviantony removed this from the 2.1 milestone Oct 28, 2020
@Re4zOon Re4zOon mentioned this pull request Apr 28, 2022
Closed
chiptus added a commit to chiptus/portainer that referenced this pull request Aug 16, 2023
@chiptus
fix(auth/ldap): allow to search in users table (portainer#3484)
139a089
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
has conflicts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to log into Portainer with initial password
2 participants
@WnP @deviantony