Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(registries): check same url for gitlab #3870

Merged
merged 1 commit into from Jun 4, 2020
Merged

fix(registries): check same url for gitlab #3870

merged 1 commit into from Jun 4, 2020

Conversation

chiptus
Copy link
Contributor

@chiptus chiptus commented May 28, 2020 •
edited

fix #3839

@chiptus chiptus requested a review from deviantony May 28, 2020 06:41
@chiptus chiptus linked an issue May 28, 2020 that may be closed by this pull request
Cannot give access to gitlab registry when there are multiple defined #3839
Closed
@deviantony deviantony requested a review from a user June 2, 2020 04:07
@deviantony deviantony changed the base branch from 2.0 to develop June 2, 2020 23:41
@deviantony
Copy link
Member

Please rebase that PR on the develop branch.

@chiptus chiptus force-pushed the fix3839-fix-registry-same-url branch from 74c29c8 to 7d40b9f Compare June 3, 2020 05:09
@pull-dog
Copy link

pull-dog bot commented Jun 3, 2020

*Ruff* 🐶 I am running in lazy mode (as per your pull-dog.json configuration file), so I won't start provisioning a test environment for this pull request until I hear from your build server 💤 Give it a few minutes, and check back.

React on this comment to leave anonymous feedback.

  • 👍 to say good dog 🍖
  • 👎 to say bad dog 🦴
Commands
  • @pull-dog go fetch to reprovision or provision the server.
  • @pull-dog get lost to delete the provisioned server.

@deviantony deviantony removed their request for review June 4, 2020 05:17
@deviantony
Copy link
Member

@itsconquest assign and ping me for review after yours is done.

ghost
ghost approved these changes Jun 4, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost
Copy link

ghost commented Jun 4, 2020

@deviantony rtr

@ghost ghost requested a review from deviantony June 4, 2020 06:31
deviantony
deviantony approved these changes Jun 4, 2020
View reviewed changes
Copy link
Member

@deviantony deviantony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deviantony deviantony merged commit a0ba531 into develop Jun 4, 2020
@deviantony deviantony deleted the fix3839-fix-registry-same-url branch June 4, 2020 06:50
MaximeBajeux pushed a commit that referenced this pull request Jun 26, 2020
@chiptus @MaximeBajeux
fix(registries): check same url for gitlab (#3870)
868d72e
MaximeBajeux pushed a commit that referenced this pull request Jun 26, 2020
@chiptus @MaximeBajeux
fix(registries): check same url for gitlab (#3870)
9a81824
chiptus added a commit to chiptus/portainer that referenced this pull request Dec 17, 2023
@chiptus
refactor(docker/networks): migrate macvlan nodes selector to react [E…
46ceca0 
…E-4669] (portainer#3870)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deviantony deviantony deviantony approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot give access to gitlab registry when there are multiple defined
2 participants
@chiptus @deviantony