Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(telemetry): replace GA with matomo #4140

Merged
merged 22 commits into from
Aug 6, 2020
Merged

Conversation

chiptus
Copy link
Contributor

@chiptus chiptus commented Aug 3, 2020

fix #3742

@chiptus chiptus requested a review from deviantony August 3, 2020 09:43
@pull-dog
Copy link

pull-dog bot commented Aug 3, 2020

*Ruff* 🐶 The test environment for this pull request has been destroyed 💥 This may have happened explicitly via a command, because the environment expired, or because the pull request was closed.

What is this?

Pull Dog is a GitHub app that makes test environments for your pull requests using Docker, from a docker-compose.yml file you specify. It takes 19 seconds to set up (we counted!) and there's a free plan available.

Visit our website to learn more.

Commands
  • @pull-dog up to reprovision or provision the server.
  • @pull-dog down to delete the provisioned server.
Troubleshooting

Need help? Don't hesitate to file an issue in our repository

Configuration

{"isLazy":false,"dockerComposeYmlFilePaths":["docker-compose.yml"],"buildArguments":{"PORTAINER_TAG":"pr4140-linux-amd64"},"expiry":"00:00:00","conversationMode":"singleComment"}

Trace ID
a964a380-d836-11ea-8e09-9a2ae48c7931

Copy link
Member

@deviantony deviantony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM

Needs a rebase @chiptus

@chiptus
Copy link
Contributor Author

chiptus commented Aug 4, 2020

done

@deviantony
Copy link
Member

@chiptus can you take care of the rebase on that one?

Copy link
Member

@deviantony deviantony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deviantony deviantony merged commit 2158cc5 into develop Aug 6, 2020
@deviantony deviantony deleted the feat3742-matomo-telemetry branch August 6, 2020 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce custom telemetry
2 participants