feat (container): quickly editing environment variables (#546)

[Filirom1]

Hello,

Is it something like this you were thinking of in #546 ?

If so, I can apply it to all key-value components.

Cheers
Romain

[ncresswell]

Yup, pretty much. That "mass text field" is what i had in mind... Rgds, Neil Cresswell On 6/02/2017, at 9:09 AM, Romain <notifications@github.com<mailto:notifications@github.com>> wrote: Hello, Is it something like this you were thinking of in #546<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_portainer_portainer_issues_546&d=DQMCaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=0fx0h4vB56iTLpw2McH1ZD6TqG_QGpbggVOB-PfMJpM&m=eaSHq2oMPQrQnaNjHcnthxawyx2ePS26rqpPMcVV9Ns&s=Ku5AIU7k3LW4T_4yBMY3BFRH6Z8xZsxq9X1b5fYAELw&e=> ? [env]<https://urldefense.proofpoint.com/v2/url?u=https-3A__cloud.githubusercontent.com_assets_295554_22629483_3abd80da-2Debe7-2D11e6-2D9c0f-2De962a5b4f1e5.gif&d=DQMCaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=0fx0h4vB56iTLpw2McH1ZD6TqG_QGpbggVOB-PfMJpM&m=eaSHq2oMPQrQnaNjHcnthxawyx2ePS26rqpPMcVV9Ns&s=uIUBW_6PHoHASP49YnB3R7PPi-mqTPLZNZkf6qqtaF4&e=> If so, I can apply it to all key-value components. Cheers Romain

…

________________________________ You can view, comment on, or merge this pull request online at: #570<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_portainer_portainer_pull_570&d=DQMCaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=0fx0h4vB56iTLpw2McH1ZD6TqG_QGpbggVOB-PfMJpM&m=eaSHq2oMPQrQnaNjHcnthxawyx2ePS26rqpPMcVV9Ns&s=_Otw48uTtkOadevxAEMk0i_aYeZsyogg44YDPJgLtX8&e=> Commit Summary * feat (container): quickly editing environment variables (#546) File Changes * M app/components/container/container.html<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_portainer_portainer_pull_570_files-23diff-2D0&d=DQMCaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=0fx0h4vB56iTLpw2McH1ZD6TqG_QGpbggVOB-PfMJpM&m=eaSHq2oMPQrQnaNjHcnthxawyx2ePS26rqpPMcVV9Ns&s=CnJYXrIGd98Nfupbtp-Ssi93BBf53LUPr4rFFHJDNIQ&e=> (9) * M app/components/createContainer/createContainerController.js<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_portainer_portainer_pull_570_files-23diff-2D1&d=DQMCaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=0fx0h4vB56iTLpw2McH1ZD6TqG_QGpbggVOB-PfMJpM&m=eaSHq2oMPQrQnaNjHcnthxawyx2ePS26rqpPMcVV9Ns&s=EMJIVF1vdmQyIJ2vsV0tvPMjPlHMtigilveHyY8p0DU&e=> (19) * M app/components/createContainer/createcontainer.html<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_portainer_portainer_pull_570_files-23diff-2D2&d=DQMCaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=0fx0h4vB56iTLpw2McH1ZD6TqG_QGpbggVOB-PfMJpM&m=eaSHq2oMPQrQnaNjHcnthxawyx2ePS26rqpPMcVV9Ns&s=Q8ccaCbeFwJtU_R6geUxuXCbkXRpfiz1F4hJRBy_mrs&e=> (25) Patch Links: * #570.patch<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_portainer_portainer_pull_570.patch&d=DQMCaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=0fx0h4vB56iTLpw2McH1ZD6TqG_QGpbggVOB-PfMJpM&m=eaSHq2oMPQrQnaNjHcnthxawyx2ePS26rqpPMcVV9Ns&s=cuApGF4Ub53Ae4jz19VQRKZYWs81NtspHETvQocg0Ms&e=> * #570.diff<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_portainer_portainer_pull_570.diff&d=DQMCaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=0fx0h4vB56iTLpw2McH1ZD6TqG_QGpbggVOB-PfMJpM&m=eaSHq2oMPQrQnaNjHcnthxawyx2ePS26rqpPMcVV9Ns&s=yKUB95DWnqweChP2GrSWQg8bk5DH2Vn-ygmaHDK2Sbo&e=> — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_portainer_portainer_pull_570&d=DQMCaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=0fx0h4vB56iTLpw2McH1ZD6TqG_QGpbggVOB-PfMJpM&m=eaSHq2oMPQrQnaNjHcnthxawyx2ePS26rqpPMcVV9Ns&s=_Otw48uTtkOadevxAEMk0i_aYeZsyogg44YDPJgLtX8&e=>, or mute the thread<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AWGrlSAF3cBTaqpXVIEbebQXpS3xTtDxks5rZiyRgaJpZM4L3m6V&d=DQMCaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=0fx0h4vB56iTLpw2McH1ZD6TqG_QGpbggVOB-PfMJpM&m=eaSHq2oMPQrQnaNjHcnthxawyx2ePS26rqpPMcVV9Ns&s=oEMHjrhcjH7F4WjUWH2OeLARw_fhVoRYfykOmI_k-jU&e=>.

[deviantony]

ping @psykzz

Have a look at the provided example and tell us what you think.

[psykzz]

That's perfect!

Exactly what i was looking for

[thojkooi]

I feel this should be done in addition to the existing edit environment variables functionality. Perhaps with some toggle button to switch between both edit modes?

[ncresswell]

Agree.. "Standard" or "Bulk" Rgds, Neil Cresswell On 6/02/2017, at 11:12 AM, Glowbal <notifications@github.com<mailto:notifications@github.com>> wrote: I feel this should be done in addition to the existing edit environment variables functionality. Perhaps with some toggle button to switch between both edit modes? — You are receiving this because you commented. Reply to this email directly, view it on GitHub<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_portainer_portainer_pull_570-23issuecomment-2D277554065&d=DQMCaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=0fx0h4vB56iTLpw2McH1ZD6TqG_QGpbggVOB-PfMJpM&m=y62-4Kdubqjsh21okRtVCDipPzpyPM2-aj7ezzBNFlY&s=1A1lUmlZk2z2YBrwPDE-T_3Upxeh9El4J5SVSJwNDzs&e=>, or mute the thread<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AWGrlYWfU2wsCxNITShNs4oW4ENkOkOwks5rZkkzgaJpZM4L3m6V&d=DQMCaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=0fx0h4vB56iTLpw2McH1ZD6TqG_QGpbggVOB-PfMJpM&m=y62-4Kdubqjsh21okRtVCDipPzpyPM2-aj7ezzBNFlY&s=NGk8S8WVxZiLLBXpBrGuoSZmu7dZD7Db8WnzM1Pb7Kk&e=>.

[Filirom1]

Having 2 modes for doing the same thing is not my prefered solution. It makes the user interface more complex and increase the number of click needed by the user to get to it.

I am aware that, it looks less sophisticated, but it's more powerful.

I tried to make it prettier, but when I add span to separate keys and values, the copy/paste function of Chrome add extra spaces between keys and values that are unwanted

[deviantony]

@Filirom1 got a point. I do think that having multiple modes is bad for the UX.

On the other side, I feel that somehow this enhancement goes against the will behind Portainer which is really simple user experience.

Maybe we can mix both of the world by having the browser remembering which mode is selected so that when the user goes back to the container-creation view the last mode he used will be displayed.

@ncresswell what do you think?

[ncresswell]

I dont see the issue with having a collapsed "advanced settings" like we do elsewhere... so the default behaviour is simple, but if needed, a user can expand the advanced section and gain more controls.

…

Sent from my iPad On 8/02/2017, at 4:56 PM, Anthony Lapenna <notifications@github.com<mailto:notifications@github.com>> wrote: @Filirom1<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Filirom1&d=DQMFaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=0fx0h4vB56iTLpw2McH1ZD6TqG_QGpbggVOB-PfMJpM&m=7hjL38sYYXcLfHVKiRdytT9qXdbXQyj3LWKRLcCfyTU&s=a8w8VARjaWlBKshmC7u6ms8M0kafpkqSBCzkAqcjdks&e=> got a point. I do think that having multiple modes is bad for the UX. On the other side, I feel that somehow this enhancement and goes against the will behind Portainer which is really simple user experience. Maybe we can mix both of the world by having the browser remembering which mode is selected so that when the user goes back to the container-creation view the last mode he used will be displayed. @ncresswell<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_ncresswell&d=DQMFaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=0fx0h4vB56iTLpw2McH1ZD6TqG_QGpbggVOB-PfMJpM&m=7hjL38sYYXcLfHVKiRdytT9qXdbXQyj3LWKRLcCfyTU&s=LX4hIaDkwNOs4QARHrZgDmuLT1dyWsd2xZzN-bwZACs&e=> what do you think? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_portainer_portainer_pull_570-23issuecomment-2D278222539&d=DQMFaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=0fx0h4vB56iTLpw2McH1ZD6TqG_QGpbggVOB-PfMJpM&m=7hjL38sYYXcLfHVKiRdytT9qXdbXQyj3LWKRLcCfyTU&s=eRMpaqLZGHoOLPKY788_8rbo4aKbyutMQlrycvtZHCU&e=>, or mute the thread<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AWGrlSsdfMB-5F3n9-2DRtAgOq8QPaRJLgYUks5raTzlgaJpZM4L3m6V&d=DQMFaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=0fx0h4vB56iTLpw2McH1ZD6TqG_QGpbggVOB-PfMJpM&m=7hjL38sYYXcLfHVKiRdytT9qXdbXQyj3LWKRLcCfyTU&s=zliedLmP-UcW52aupiHsjF26y_ip8Verle6txtqJEVc&e=>.

[deviantony]

@Filirom1 would you be able to implement it as an 'advanced settings' behavior?

[deviantony]

Any update on that PR @Filirom1 ?

[deviantony]

ping @Filirom1

[metehus]

updates on this?

[ghost]

Closing as we now have the ability to add multiple key val pairs for env vars via a text box via advanced mode