Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docker/containers): new nvidia container toolkit #6872

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

dfldylan
Copy link

@dfldylan dfldylan commented May 2, 2022

closes #3143
refactor #4791

Changes:

  • based on master version 2.11.1
  • add gpus use information on backend
  • need to manual input the GPUs info at endpoint modification
  • show GPUs use at dashboard and and containers list view
  • add gpu support when create container (refactor code)
  • show gpu command equivalent on container details view (refactor code)
  • show available gpus when create container

@dfldylan dfldylan changed the title Feat/3143 new nvidia container toolkit feat(docker/containers): new nvidia container toolkit May 2, 2022
@huib-portainer
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@huib-portainer huib-portainer changed the base branch from master to develop May 5, 2022 00:59
@huib-portainer
Copy link
Contributor

Looks like this needs a rebase...

@dfldylan
Copy link
Author

dfldylan commented May 5, 2022

Sure, give me some time

@dfldylan
Copy link
Author

dfldylan commented May 5, 2022

By the way, when is the next release?

@huib-portainer
Copy link
Contributor

The next release actually is going to be next week.

@dfldylan dfldylan force-pushed the feat/3143-new-nvidia-container-toolkit branch from 95f0079 to 7b9d2b7 Compare May 13, 2022 05:38
@dfldylan
Copy link
Author

dfldylan commented May 13, 2022

@huib-portainer hello, I'm done. Please check.

  • based on develop version (after 2.13)

@huib-portainer
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@huib-portainer
Copy link
Contributor

Thanks for moving it all over and base it on the develop branch.
Currently there seems to be an issue with go test

func TestMigrateData(t *testing.T) {

image

@dfldylan dfldylan force-pushed the feat/3143-new-nvidia-container-toolkit branch 2 times, most recently from bc50d95 to 36c5401 Compare May 16, 2022 02:35
@dfldylan
Copy link
Author

Sorry, I do modify the backend definitions. Please check again. @huib-portainer

@dfldylan dfldylan force-pushed the feat/3143-new-nvidia-container-toolkit branch from 36c5401 to 7b7495e Compare May 16, 2022 03:39
@huib-portainer
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@huib-portainer
Copy link
Contributor

Unfortunately still no luck.
image

@dfldylan dfldylan force-pushed the feat/3143-new-nvidia-container-toolkit branch from 7b7495e to 1e5b7a3 Compare May 16, 2022 04:33
@dfldylan
Copy link
Author

dfldylan commented May 16, 2022

sorry ... just a extra space in json file

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 6872 in repo portainer/portainer

@huib-portainer
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@huib-portainer
Copy link
Contributor

This can be tested by using the image portainerci/portainer:pr6872.

@huib-portainer
Copy link
Contributor

The home screen now isn't loading for me:
image

@dfldylan
Copy link
Author

dfldylan commented May 16, 2022

@huib-portainer I clean my all env, and restart with portainerci/portainer:pr6872. But nothing wrong happened. Do you start in a new environment?
image
image

@huib-portainer
Copy link
Contributor

Currently the tests are failing the build
image

@dfldylan dfldylan force-pushed the feat/3143-new-nvidia-container-toolkit branch from 0390f8c to ee8a43f Compare May 18, 2022 23:45
@dfldylan
Copy link
Author

sorry, please check

@huib-portainer
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@huib-portainer
Copy link
Contributor

Actually, for the upgrade to work you'll also need to bump this one to 41

DBVersion = 35

@dfldylan dfldylan force-pushed the feat/3143-new-nvidia-container-toolkit branch from ee8a43f to 5d36e4b Compare May 25, 2022 03:09
@dfldylan
Copy link
Author

Actually, for the upgrade to work you'll also need to bump this one to 41

DBVersion = 35

I found the db40 already exists.

@huib-portainer
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@huib-portainer
Copy link
Contributor

@prabhat-org can you please advise?

Currently the build is failing because of
image

@prabhat83
Copy link
Contributor

@dfldylan Since you have updated the DB version to 41, it has to be updated in the /api/datastore/test_data/output_35.json file like you have updated other properties. I know the name is confusing; we will change the name of the file to something like output_latest.json. The property name is version.DB_VERSION.

@dfldylan dfldylan force-pushed the feat/3143-new-nvidia-container-toolkit branch from 5d36e4b to f66c116 Compare May 25, 2022 07:43
@dfldylan dfldylan force-pushed the feat/3143-new-nvidia-container-toolkit branch from f66c116 to 439393f Compare May 27, 2022 09:38
@dfldylan
Copy link
Author

Previously, only free GPUs could be selected when creating containers. Now, All GPUs can be selected, with an added hint of whether they are occupied or not.
image

@huib-portainer
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@huib-portainer
Copy link
Contributor

Thanks for bearing with us!
Upgrading an existing Portainer instance now works as well.

@dfldylan
Copy link
Author

What should I do?

@huib-portainer
Copy link
Contributor

Don't worry about the merge conflicts, we'll resolve those later.
We're aiming to release 2.14 this month and then pull this PR into the 2.15 release.
So we'll sort that out on our end.

@dfldylan
Copy link
Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for nvidia-container-toolkit and docker 19.03
4 participants