Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed CTCSS tone detection #1226

Merged
merged 3 commits into from Jul 1, 2023
Merged

Fixed CTCSS tone detection #1226

merged 3 commits into from Jul 1, 2023

Conversation

NotherNgineer
Copy link
Contributor

@NotherNgineer NotherNgineer commented Jun 30, 2023 •
edited

This change should fix the CTCSS tone detection issue #1164

@NotherNgineer NotherNgineer changed the title Fixed rounding error in received CTCSS analysis Fixed CTCSS tone detection Jul 1, 2023
@NotherNgineer NotherNgineer mentioned this pull request Jul 1, 2023
Closed
Brumi-2021
Brumi-2021 approved these changes Jul 1, 2023
View reviewed changes
Copy link
Contributor

@Brumi-2021 Brumi-2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we are solving completely the CTCSS decode in Audio Rx App.
We are fixing the freq. engine algorithm detection –now error accuracy < 0,4%–
, and updating the tone key table following Motorola key tone list from Wikipedia .

Great 👍 job , fully validated with H1R2 , H2R4

@Brumi-2021 Brumi-2021 merged commit 4e128e8 into portapack-mayhem:next Jul 1, 2023
3 checks passed
@samukas81
Copy link

Is it possible to display the direct tone, example 69.3 instead of 39 wd?

@NotherNgineer
Copy link
Contributor Author

Is it possible to display the direct tone, example 69.3 instead of 39 wd?

@samukas81 I've discussed this with Brumi and submitted enhancement issue #1228 to implement that.

@Brumi-2021
Copy link
Contributor

@samukas81 , we already opened a new issue to discuss about that new feature spec , feel free to add your comments there
issue #1228

Anyway , as advanced preliminar version, pls. find attached this binary that displays alternatively (CODE # / Tone Freq Hz )
Note , when you flash it , take care that i added to the normal name "_tone_hz"
Cheers
portapack-h1_h2-mayhem_tone_hz.zip

@samukas81
Copy link

Thank you Brumi!!

@NotherNgineer NotherNgineer deleted the tone branch July 2, 2023 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Brumi-2021 Brumi-2021 Brumi-2021 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NotherNgineer @samukas81 @Brumi-2021