Support for viewing BMP files in File Manager and setting as Splash screen #1242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kallanreed
reviewed
Jul 5, 2023
kallanreed
reviewed
Jul 5, 2023
kallanreed
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant to address enhancement #1238.
Previously, clicking on BMP files in File Manager did nothing. Now, the BMP file is displayed, and pressing the Right button will cause the displayed image file to be set as the new splash screen (copied over the existing "/splash.bmp").
Only BMP files matching the specific splash screen dimensions are supported (similar to the restrictions on viewing PNG screen-shot files).
A test version of firmware is available on Discord:
https://discord.com/channels/719669764804444213/722101917135798312/1126222765515616387