Support showing invalid entries in Freqman and allow minor edits #1269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just curious: If freqman_type::Raw is used for all "Unknown" lines in the file, I was wondering if there's still a need for the freqman_type::Unknown ? |
Unknown is the uninitialized state, Raw implies that the entry text has been read into the description. I think there’s a concept difference to warrant both. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a concept of a "Raw" freqman entry that is only persisted as a string.
This allows Freqman to show comments, invalid entries and empty lines in grey.
String data is stashed in the entry description which allows the item to be edited in Freqman's description edit mode.