updating_comments #2191
Merged
updating_comments #2191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I already investigated, the indicated "TODO" comments , that I added in yesterday's PR #2186
It is already clear , why the deleted options SSB TX BW = 4khz , was not working correctly and producing some artifacts.
In all TX modes (AM, SSB, NFM , WFM ),fs_baseband_transceiver = 1.536.000 (at RX time different ), and in parallel ,the fs_mic_Audio_capture = 24khz..
My current understanding is that to solve that SSB TX BW = 4khz, we will need to increase fs_mic_Audio_capture to 48khz,
And later make the correct adjustments and revisions in all TX modes (AM,SSB, NFM, WFM) .
This is not a big change, but it will request many test, therefore I prefer not to do it , and just keep the two added options :
SSB TX_BW (2kHz, 3kHz) .
Then this PR , will just remove my previous notes about "TODO" related to TX_BW "4KHZ" and add more correct comments.
Just in case, I checked its compilation and all working as expected ,
(Because that PR , is just updating comments without any code change)
Cheers,