Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds addtional info to loki and tempo-mixin configmaps #498

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

SonnyAD
Copy link
Contributor

@SonnyAD SonnyAD commented Aug 3, 2023

This PR adds addtionalAnnotations and annotationsLabels to the config maps for the dashboard.

@nlamirault nlamirault added status/review_needed The issue or PR needs to be reviewed priority/medium This issue or PR may be useful, and needs some attention kind/feature Categorizes issue or PR as related to a new feature lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. area/helm Helm labels Aug 3, 2023
@nlamirault
Copy link
Collaborator

could you please add also default entries into the values.yaml file ?

@nlamirault
Copy link
Collaborator

also could you try to add into helper instead of manifest file
Like that: https://github.com/portefaix/portefaix-hub/blob/master/charts/bbox-exporter/templates/_helpers.tpl#L67

@SonnyAD
Copy link
Contributor Author

SonnyAD commented Aug 4, 2023

also could you try to add into helper instead of manifest file Like that: https://github.com/portefaix/portefaix-hub/blob/master/charts/bbox-exporter/templates/_helpers.tpl#L67

Done. I also added them in loki-mixin FYI, because I need it too on my end.

Regarding the default values, I can see they already have {} set in the values.yaml. Feel free to let me know if you would like me to add anything else.

@SonnyAD SonnyAD changed the title Adds addtional info to tempo-mixin configmaps Adds addtional info to loki and tempo-mixin configmaps Aug 4, 2023
@nlamirault
Copy link
Collaborator

nlamirault commented Aug 7, 2023

Could you please make a minor change to the charts versions.
And update the changelog: https://github.com/portefaix/portefaix-hub/blob/master/charts/tempo-mixin/Chart.yaml#L53
Thanks.

@nlamirault nlamirault added status/in_progress This issue or PR is being worked on, and has someone assigned and removed status/review_needed The issue or PR needs to be reviewed labels Aug 7, 2023
@SonnyAD
Copy link
Contributor Author

SonnyAD commented Aug 8, 2023

Done, please have a look 👍

@nlamirault
Copy link
Collaborator

nlamirault commented Aug 18, 2023

could you please add default values for additional resources ?

# -- Additional labels to add to all resources
additionalLabels: {}

# -- Additional annotations to add to all resources
additionalAnnotations: {}

@nlamirault nlamirault merged commit 468f9a4 into portefaix:master Sep 1, 2023
4 of 6 checks passed
@nlamirault
Copy link
Collaborator

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm Helm kind/feature Categorizes issue or PR as related to a new feature lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/medium This issue or PR may be useful, and needs some attention status/in_progress This issue or PR is being worked on, and has someone assigned
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants