Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[alertmanager-mixin] Refactoring support for additional annotations and labels #501

Merged
merged 3 commits into from
Aug 7, 2023
Merged

[alertmanager-mixin] Refactoring support for additional annotations and labels #501

merged 3 commits into from
Aug 7, 2023

Conversation

nlamirault
Copy link
Collaborator

@nlamirault nlamirault commented Aug 7, 2023 •
edited
Loading

What this PR does / why we need it:

Which issue this PR fixes

Refactoring additional annotations and labels into Kubernetes manifests.

Special notes for your reviewer:

Checklist

  • Title of the PR starts with chart name (e.g. [portefaix-kyverno])
  • Documentation has been updated with helm-docs (run: .github/helm-docs.sh)
  • Chart Version bumped
  • ChangeLog.md has beed updated
  • Variables are documented in the README.md

@nlamirault
Update: Refactoring support for additional annotations and labels
6e8a994 
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
@github-actions github-actions bot added the size/m Size M label Aug 7, 2023
@nlamirault nlamirault changed the title Update: Refactoring support for additional annotations and labels [alertmanager-mixin] Refactoring support for additional annotations and labels Aug 7, 2023
@nlamirault nlamirault added status/review_needed The issue or PR needs to be reviewed priority/low This issue can probably be picked up by anyone looking to contribute to the project, as an entry fix lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt area/helm Helm labels Aug 7, 2023
@nlamirault
Fix: ConfigMapList name and dashboards names
4351286 
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
@github-actions github-actions bot added the size/xl Size XL label Aug 7, 2023
@nlamirault
Fix: indentation
ab1ace4 
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
@nlamirault nlamirault merged commit 608915c into master Aug 7, 2023
10 of 11 checks passed
@nlamirault nlamirault deleted the feat/alertmanager-mixin-add-labels-annotations branch August 7, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/helm Helm kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/low This issue can probably be picked up by anyone looking to contribute to the project, as an entry fix size/m Size M size/xl Size XL status/review_needed The issue or PR needs to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@nlamirault