Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[secrets-store-csi-driver-provider-gcp] Chart fixes and updates #698

Conversation

milesarmstrong
Copy link
Contributor

@milesarmstrong milesarmstrong commented Mar 14, 2024

What this PR does / why we need it:

  • Fixes a chart rendering error in a few templates, the -}} just before the start of the resource template chomps the newline and means the apiVersion field of the resource ends up as part of the header comment.
    • pre fix:
      ➜  helm template . -f values.yaml | kubeconform -kubernetes-version "1.27.8" -summary -ignore-missing-schemas -schema-location default
      stdin - ServiceAccount release-name-secrets-store-csi-driver-provider-gcp failed validation: error while parsing: missing 'apiVersion' key
      stdin - ClusterRole release-name-secrets-store-csi-driver-provider-gcp failed validation: error while parsing: missing 'apiVersion' key
      stdin - ClusterRoleBinding release-name-secrets-store-csi-driver-provider-gcp failed validation: error while parsing: missing 'apiVersion' key
      Summary: 4 resources found parsing stdin - Valid: 1, Invalid: 0, Errors: 3, Skipped: 0
    • post fix:
      ➜  helm template . -f values.yaml | kubeconform -kubernetes-version "1.27.8" -summary -ignore-missing-schemas -schema-location default
      Summary: 4 resources found parsing stdin - Valid: 4, Invalid: 0, Errors: 0, Skipped: 0
  • Bump the default application version to 1.5.0
  • Bring the various security improvements that have been added to the Chart in the application repo

Which issue this PR fixes

N/A

Special notes for your reviewer:

Checklist

  • Title of the PR starts with chart name (e.g. [portefaix-kyverno])
  • Documentation has been updated with helm-docs (run: .github/helm-docs.sh)
  • Chart Version bumped
  • Variables are documented in the README.md

@milesarmstrong milesarmstrong force-pushed the miles/secrets-store-csi-driver-provider-gcp-updates branch from bdf1fad to f879b90 Compare March 14, 2024 15:10
@milesarmstrong milesarmstrong force-pushed the miles/secrets-store-csi-driver-provider-gcp-updates branch from f879b90 to cade04d Compare March 14, 2024 15:12
@milesarmstrong
Copy link
Contributor Author

Hi @nlamirault, please could you review this change!

@nlamirault nlamirault added status/review_needed The issue or PR needs to be reviewed priority/medium This issue or PR may be useful, and needs some attention kind/feature Categorizes issue or PR as related to a new feature lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. area/helm Helm labels Mar 15, 2024
@nlamirault nlamirault merged commit 715779b into portefaix:master Mar 15, 2024
15 of 17 checks passed
@milesarmstrong
Copy link
Contributor Author

@nlamirault thanks for the merge!

Looks like the release on master failed due to an issue with re-releasing kubewarden: https://github.com/portefaix/portefaix-hub/actions/runs/8300331483/job/22718025094#step:7:86

@nlamirault
Copy link
Collaborator

done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm Helm kind/feature Categorizes issue or PR as related to a new feature lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/medium This issue or PR may be useful, and needs some attention status/review_needed The issue or PR needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants