addon status and preflight check #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
porter/v1/addons.proto
Outdated
| // ADDON_STATUS_INFRA_PROVISIONING_FAILED is the status when an addon can't be installed due to a failed infrastructure reprovisioning | ||
| ADDON_STATUS_INFRA_PROVISIONING_FAILED = 4; | ||
| // ADDON_STATUS_DEPLOYING is the status when an addon is being deployed | ||
| ADDON_STATUS_DEPLOYING = 5; |
There was a problem hiding this comment.
should this be ADDON_STATUS_INSTALLED? when the frontend makes the query, it wants to know whether a model is installed, after which it can render the deployment status
ferozemohideen
approved these changes
Jun 5, 2024
| // deployment_target_identifier is the object that identifies the deployment target for the addon | ||
| // If cluster_id is specified and deployment_target_identifier is not, then the default deployment target for the provided cluster will be used | ||
| DeploymentTargetIdentifier deployment_target_identifier = 3; | ||
| AddonType addon_type = 4; |
There was a problem hiding this comment.
this should take in the entire addon config. example is if we ever want to expose the instance type of the deepgram addon to client, that will require different quotas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.