Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Fixed scroll to bottom not doing anything or partially working #1736

Merged
merged 1 commit into from Mar 9, 2022

Conversation

jnfrati
Copy link
Contributor

@jnfrati jnfrati commented Mar 9, 2022

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Other (please describe):

Pull request checklist

Please check if your PR fulfills the following requirements:

  • If it's a backend change, tests for the changes have been added and go test ./... runs successfully from the root folder.
  • If it's a frontend change, Prettier has been run
  • Docs have been reviewed and added / updated if needed

Motivation

The scroll to bottom functionality was either not working or working some times at the start or at the middle of the stream.
This PR tries to solve it by calling the function scroll to bottom each time we get a message from the websocket that streams logs.

@jnfrati jnfrati self-assigned this Mar 9, 2022
@abelanger5 abelanger5 merged commit 0a133d5 into master Mar 9, 2022
@abelanger5 abelanger5 deleted the nico/fix-scroll-to-bottom-on-logs branch October 26, 2022 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants