[0.6.0] Fixes #897 -- --path
flag inconsistencies for porter update build
#906
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
Pull request checklist
Please check if your PR fulfills the following requirements:
go test ./...
runs successfully from the root folder.What is the current behavior?
Issue Number: #897
Is really three issues:
--path
flag isn't used when--source github
, although it should be used to specify the relative path from the repository root to the build context--dockerfile
flag isn't used when--source github
, although it should be used to specify the relative path from the repository root to the dockerfile--dockerfile
path isn't added to the Docker build context if it's outside of the build contextTechnical Spec/Implementation Notes
Function copied from Docker CLI, since importing the Docker CLI broke our go modules.