Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.6.0] Fixes #897 -- --path flag inconsistencies for porter update build #906

Merged
merged 6 commits into from Jul 23, 2021

Conversation

abelanger5
Copy link
Contributor

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Other (please describe):

Pull request checklist

Please check if your PR fulfills the following requirements:

  • If it's a backend change, tests for the changes have been added and go test ./... runs successfully from the root folder.
  • If it's a frontend change, Prettier has been run
  • Docs have been reviewed and added / updated if needed

What is the current behavior?

Issue Number: #897

Is really three issues:

  • --path flag isn't used when --source github, although it should be used to specify the relative path from the repository root to the build context
  • --dockerfile flag isn't used when --source github, although it should be used to specify the relative path from the repository root to the dockerfile
  • the --dockerfile path isn't added to the Docker build context if it's outside of the build context

Technical Spec/Implementation Notes

Function copied from Docker CLI, since importing the Docker CLI broke our go modules.

@abelanger5 abelanger5 merged commit 3f3071c into master Jul 23, 2021
@abelanger5 abelanger5 deleted the 0.6.0-897-path-cli-arg branch August 9, 2021 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant