Comdirect PDF Importer: use of manually changed test documents; use of tax documents

[buchen]

Keep track of changes needed for the Comdirect Importer:

@Nirus2000 commented in #3305

2. the problem is here also that in the ComDirect still some "manipulated" PDF debugs are and the tests say "Ok", but are not actually.

3. also tax documents were misused for dividend transactions or sales.

4. also withholding taxes appear in the regular dividend transactions, but no longer in the tax treatment.

[buchen]

About 2) "manipulated" PDF text documents

If I get it right, there are text documents that have been manually changed and that do not reflect the way the PDF->Text converter would create the text, right? Do you know which the text documents? What is your plan?

My first reaction is: let's delete the wrong text documents and the tests that go with it (but not the code in the extractor). Then, over time, add correct documents -> and adopt the code accordingly. The problem with keeping around the old documents is that the tests lock-in the wrong code.

About 3) "tax documents were misused for dividend transactions or sales"

I am not sure I understand what the problem is.

About 4) "withholding taxes no longer in tax treatment"

That does sound not like a bug per se, but that the bank is now reporting withholding taxes in the proper document. I guess the challenge is how to keep it backward compatible. Ideally, a new user can import the last X years of documents to create the correct history of his holdings. Or am I missing something here?