Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplification of the identification of tags (PDF importer) #3795

Closed
Nirus2000 opened this issue Feb 17, 2024 · 0 comments
Closed

Simplification of the identification of tags (PDF importer) #3795

Nirus2000 opened this issue Feb 17, 2024 · 0 comments
Assignees

Comments

@Nirus2000
Copy link
Member

Nirus2000 commented Feb 17, 2024

Hello @buchen
I think we need a function analogous to the check by documentContext("currency") to move the PeriodicHelper or similar into the extractutils.
For example, baseCurrency and year should be found. (see Postbank PDF Importer)

The other point is that I can only check one currency via check in the tests, but not EUR, USD, GPB, CHF
new AssertImportActions().check(results, CurrencyUnit.EUR);
However, if I only check one currency, it is always displayed incorrectly. We need a list of currencies.

What did you think?

Originally posted by @Nirus2000 in #3789 (comment)

buchen added a commit that referenced this issue Feb 27, 2024
Range attributes are only valid within a given block, i.e. a start and
and end line number. In order to use range attributes, one has to
* add range blocks to the document type
* add a rangeAttribute() to the section

If the given attribute does not exist, the parsing of the document fails.

Issue: #3795
buchen added a commit that referenced this issue Feb 29, 2024
Range attributes are only valid within a given block, i.e. a start and
and end line number. In order to use range attributes, one has to
* add range blocks to the document type
* add a rangeAttribute() to the section

If the given attribute does not exist, the parsing of the document fails.

Issue: #3795
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants