Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Save as" binary ends with loss of prices from the future #3935

Closed
ProgFriese opened this issue Apr 13, 2024 · 2 comments
Closed

"Save as" binary ends with loss of prices from the future #3935

ProgFriese opened this issue Apr 13, 2024 · 2 comments
Labels

Comments

@ProgFriese
Copy link

Describe the bug
If you import a csv with quotes in the future
quotes_in_future.csv.zip
into an xml file everything is fine. Save the xml as binary and the future quotes are lost.

To Reproduce
If you import the csv with the prices from the future into the file test.xml, save and close the file, the future prices are still there after reopening the file test.xml (as expected).
Now save as binary test.portfolio, then close and reopen. Now the quotes from the future have disappeared into nirvana.

Expected behavior
I would have expected the future quotes to remain in binary format as well

Desktop (please complete the following information):

  • OS: Linux
  • Version 0.68.3

Also described by other people: https://forum.portfolio-performance.info/t/kurse-in-der-zukunft-aus-csv-importieren/28090/15

@ProgFriese ProgFriese added the bug label Apr 13, 2024
@buchen
Copy link
Member

buchen commented Apr 16, 2024

it's a bug. Only via CSV, it is possible to insert future prices. I will fix it so that the prices are kept.

buchen added a commit that referenced this issue May 10, 2024
Previously, the protobuf reading was using the #addAllPrices method
to recreate the prices of an instrument. However, this method does not
insert future prices while it is possible (and sometimes reasonable)
to import future prices via CSV.

Issue: #3935
@buchen
Copy link
Member

buchen commented May 10, 2024

Fixed.

@buchen buchen closed this as completed May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants