Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "Earnings & Expense" to "Income & Expenses" #2084

Closed
wants to merge 3 commits into from
Closed

Change "Earnings & Expense" to "Income & Expenses" #2084

wants to merge 3 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Feb 13, 2021

by implementing optionally trades

In memory of PR #1380 and the case that values from trades are based on calculations rather than fixed bookings and recently repitly asked by the community I've recreated my former PR with few options:;

  1. User could decide if they would like to use the calculated earnings from the trade view. Depend on the decission, the icon option were enabled or disabled.
    EnabledDisabledTradeIcon
    New Flags

  2. As the user claimed the k-amount scalling for small amounts I've slighly changed the formatting more intuitive
    AdjustedScalling

  3. Finally (unfortnately I didn*t find the forum thread) there was asked to consolidate the retired securities to get only the active once. This is available as option as well.
    RetiredSecurities1
    RetiredSecurities

Skalierung der Grafik:
https://forum.portfolio-performance.info/t/skalierung-der-y-achse-im-diagramm-vermoegensaufstellung/1892
https://forum.portfolio-performance.info/t/skala-bei-ertraege-akkumuliert-veraendern/8382

Trades unter "Einnahmen & Ausgaben" aka "Erträge & Ausgaben"
https://forum.portfolio-performance.info/t/gewinne-verluste-aus-trades-unter-ertraege-und-ausgaben/6922
https://forum.portfolio-performance.info/t/anzeige-von-veraeusserungsgewinnen/86

Warm regards
Marco

#2063

@buchen
Copy link
Member

buchen commented Feb 20, 2021

In memory of PR #1380 and the case that values from trades are based on calculations rather than fixed bookings and recently repitly asked by the community I've recreated my former PR with few options

I like the change towards the formatting of the Y-Axis and the consolidation of inactive securities.

The only remark for me would be: the summary line "inactive securities" should only show up if there are inactive securities that actually have values. Adding a line with just zeros does add noise to the UI.

Then about the discussion we already had in #1380:

I still do not think there is super clear case to mix these numbers. But I understand the argument one wants to look at all "Kapitalerträge" and that includes dividends, fixed income, and realized capital gains. That is valid so let's add the realized gains from closed trade (you got me 😉).

Now let's talk about the implementation:

What I do not like is that we have now two things: the button in the toolbar and the entry in the drop down menu.
Why don't we add the "Realized gains" as an element to the toolbar, and include it always in the "sum" element?

@buchen
Copy link
Member

buchen commented Feb 28, 2021

Merged.

There is a new tab "closed trades" now. I have removed the menu item in the configuration menu. That addresses the point I mention above: having both a tool bar and a menu entry.

@buchen buchen closed this Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants