Recognize more comdirect documents #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This (should) fix issue #277. As I did not want to have another counter to see how many words I have to jump, I relied on 'the last word on the line'. As I needed more functionality for that, I took the liberty of replacing some
while charAt incr/decrloops by callingindexOf/lastIndexOfinstead.Additionally it recognizes more documents, where it does not say 'Zum Kurs von' but different things (I've seen 'Zum comdirect Preis von' and 'Zum Preis von' so far). I have achieved that by checking for 'Nennwert' instead. I hope that does not break anything.