-
Notifications
You must be signed in to change notification settings - Fork 584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new Sedol security idenitification for new AJ Bell Securities Limited PDF-Importer #2963
Add new Sedol security idenitification for new AJ Bell Securities Limited PDF-Importer #2963
Conversation
(grrr... I just typed up a long response and now the input field is empty again 😬... let me type up the short version) I never heard about Sedol. I understand it as a country-local security identification number very similar to the WKN (which is the local identification number for Germany). And reading the Wikipedia, one is also convertible:
and
I am hesitant to add new fields. Maybe the mistake was already to add "WKN" (which is the German Wertpapierkennnummer). If we add something for the Britisch/Irish, then what about the French, Spanish, ...? What can we do?
|
Hello @buchen
I know, this has also happened to me several times... 😞 😞 😞 I understand your point of view.
The CUSIP is used e.g. in IBFlexQuery or also in the Score Priority Corp. PDF importer. Let's make a separate branch for this again, then I can do some of the work again. 👍🏻 I like the idea that we convert the WKN into a country specific security identifier. What would we need to consider?
Ah... there I went again with a hit.... well, PP is developing globally and we should set the course for this. Greetings |
❤️ Thanks. That is a nice overview. This is something we can target. (And then we can throw in the notationId for good measure). Before we implement, let's try to understand some boundary conditions. Can a security have a WKN (german identification) and and Sedol (British) at the same time? I am asking because the transformation rules to the ISIN would be different (the British would add the GB, pad some 0, and add the check digit. What about this behavior: a security can have any of those identification numbers. From the UI, they are not all displayed. Only if the security has it maintained, it is shown. But any can be added (say: "add CUSIP" via some button/dropdown). We have a predefined list of possible identification numbers (because the code must understand that it now looks for the SEDOL). From the persistence point of view, I am torn between adding direct XML properties (as you have done in the PR) or using the Attribute mechanism (which is backed by a hash map). The former is easier in the code, but bloats the XML, can never be changed. The latter is more flexible, keeps the storage format nimble and the XML small, but requires some helper code. We would have to try, but we could use the Attributes "as is" but attached to the InvestmentVehicle (instead of Security) and have a configuration that is not changeable by the users |
@buchen to answer one of your questions - yes, it's possible for a security to have both a SEDOL and a WKN. I found the following from a random Google: ISIN: LU0346392219 (https://www.fidelityinternational.com/FILPS/Documents/en/current/ret.en.xx.LU0346392219.pdf) I'm guessing it's common when listed on multiple exchanges. I'm also not sure the SEDOL -> ISIN conversion you mention is often used - particularly as often funds will not be domiciled in the UK. Searching for GB00BNTC2230 (adding GB00 and a 0 ISIN check code to the above SEDOL) for instance yields zero references. |
Hello @buchen As @jamescrowley mentioned, a security can have any or all of these identification numbers. ISIN: WKN: CUSIP: VALOR: SEDOL: FIGI: |
https://forum.portfolio-performance.info/t/pdf-import-from-ajbell-youinvest/21679 Add new datetime format in PDFExtractorUtils.java Add more new transactions https://forum.portfolio-performance.info/t/pdf-import-from-aj-bell-securities-youinvest/21679/3 Add new Sedol security idenitification Add new Sedol security idenitification for PDF Importer (same like ISIN or WKN) https://de.wikipedia.org/wiki/Stock_Exchange_Daily_Official_List
@Nirus2000 any reason this was closed? It would be great to have this work brought to fruition eventually. |
https://forum.portfolio-performance.info/t/pdf-import-from-ajbell-youinvest/21679
https://forum.portfolio-performance.info/t/pdf-import-from-aj-bell-securities-youinvest/21679/3
Add new datetime format in PDFExtractorUtils.java
Add new "Sedol" security idenitification for PDF Importer (same like ISIN or WKN)
https://en.wikipedia.org/wiki/SEDOL
Hello @buchen
i for this PDF importer a new security identifier is needed. This I have hopefully been able to implement completely. I add also some new testCase and improve some source code.
At least I tried 😬
However, I failed with the implementation in the protobuf. I don't understand this one.
If necessary, something would still have to be triggered via the client factory that updates the existing securities.
Greetings
Alex