Improve some colors for dark theme #3614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OnkelDok
reviewed
Oct 29, 2023
name.abuchen.portfolio.ui/src/name/abuchen/portfolio/ui/views/SecuritiesChart.java
Outdated
Show resolved
Hide resolved
Nirus2000
force-pushed
the
Improve-some-colors-for-dark-theme
branch
from
9d8090e
to
9b50b81
Compare
|
Thanks @Nirus2000. Looking at the screenshots, the colors seem to be an improvement. I will merge it. BTW, if we want to have different colors for the light or dark theme, then it is possible to extend the CSS handler for the SecurityChart. At the moment, only the color for the historical price ("quote-color") is managed via CSS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://forum.portfolio-performance.info/t/dark-mode-fur-pp/3739/84
The screenshot does not show this quite as well, but it is significantly better than before.
Left new <--> right old
(Click picture to expand)
