Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverse #2752 Logos are cut off on the left in OS_WIN #3615

Closed
wants to merge 1 commit into from
Closed

Reverse #2752 Logos are cut off on the left in OS_WIN #3615

wants to merge 1 commit into from

Conversation

Nirus2000
Copy link
Member

Reverse #2752
Logos are no longer cut off on the left under OS_WIN32

https://forum.portfolio-performance.info/t/dark-mode-fur-pp/3739/75

@Nirus2000
Copy link
Member Author

Nirus2000 commented Oct 29, 2023 •
edited

Hello @buchen
The Logo...
Logo_Bayer_remove_background
grafik
What surprises me is that the transparent background is not accepted. Do you know why?

I could not fix this error.
The columns are wider than needed.
grafik

Alex

@Morpheus1w3
Copy link
Contributor

@Nirus2000
Transparency and SWT with adjusting the scaling will be tricky as described at https://stackoverflow.com/questions/58171769/how-to-scale-a-transparent-org-eclipse-swt-graphics-image-loaded-from-a-png-ja

buchen
buchen requested changes Oct 30, 2023
View reviewed changes
Copy link
Member

@buchen buchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change.

I have not tested on Windows lately. So it is good news that the x offset of 1 is not needed anymore.

name.abuchen.portfolio/src/name/abuchen/portfolio/model/ImageManager.java Outdated Show resolved Hide resolved
name.abuchen.portfolio/src/name/abuchen/portfolio/model/ImageManager.java Outdated Show resolved Hide resolved
@buchen buchen mentioned this pull request Oct 30, 2023
Closed
@buchen
Copy link
Member

buchen commented Oct 30, 2023

Then about the transparency. The SWT framework has its challenges...

Let's move the discussion about transparency to a separate issue: #3619

I could not fix this error.
The columns are wider than needed.

@Nirus2000 - can you provide some more details (maybe in a separate issue)?
My understanding is: the columns have whatever width the user has given them (by resizing it via double click). If one double-clicks on the column header (or on the line between two column headers), it should resize the column to the widest value.

@Nirus2000 Nirus2000 force-pushed the everse-#2752-Logos-are-cut-off-on-the-left-in-OS_WIN branch from e69906e to af7e53a Compare October 30, 2023 15:14
@Nirus2000 Nirus2000 mentioned this pull request Oct 30, 2023
Open
@Nirus2000 Nirus2000 requested a review from buchen October 30, 2023 15:23
buchen pushed a commit that referenced this pull request Oct 31, 2023
@Nirus2000 @buchen
Removes 1 pixel offset for icons on Windows
ab7f812 
From feedback in the forum, we understand that the 1 pixel shift
introduced with #2752 is not necessary anymore.

Issue: https://forum.portfolio-performance.info/t/dark-mode-fur-pp/3739/75
Issue: #3615
Signed-off-by: Nirus2000 <webmaster@nirus-online.de>
[reformatted to code format; rebased to master]
Signed-off-by: Andreas Buchen <andreas.buchen@gmail.com>
@buchen
Copy link
Member

buchen commented Oct 31, 2023

rebased and merged.

@buchen buchen closed this Oct 31, 2023
@Nirus2000 Nirus2000 deleted the everse-#2752-Logos-are-cut-off-on-the-left-in-OS_WIN branch October 31, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buchen buchen Awaiting requested review from buchen

Assignees
No one assigned
Labels
quick_win
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Nirus2000 @Morpheus1w3 @buchen