Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new PDF Importer for J&T Direktbank #3748

Merged
merged 7 commits into from Jan 20, 2024

Conversation

ZfT2
Copy link
Contributor

@ZfT2 ZfT2 commented Jan 17, 2024

support J&T Direktbank Tagesgeldkonto-Auszüge

@Nirus2000 Nirus2000 self-requested a review January 17, 2024 15:34
@Nirus2000 Nirus2000 added the pdf label Jan 17, 2024
Copy link
Member

@Nirus2000 Nirus2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ZfT2 ,
thanks for the contributions.
It generally looks good to me.
Have a look at the review comments I added.

@Nirus2000 Nirus2000 self-assigned this Jan 17, 2024
ZfT2 and others added 3 commits January 17, 2024 16:55
…/pdf/JTDirektbankPDFExtractor.java


changed RegEx to contributing standard

Co-authored-by: Alexander Ott  <45203494+Nirus2000@users.noreply.github.com>
…/pdf/JTDirektbankPDFExtractor.java


changed RegEx to contributing standard

Co-authored-by: Alexander Ott  <45203494+Nirus2000@users.noreply.github.com>
ZfT2 and others added 2 commits January 18, 2024 14:03
…/pdf/JTDirektbankPDFExtractor.java


changed RegEx to contributing standard

Co-authored-by: Alexander Ott  <45203494+Nirus2000@users.noreply.github.com>
@ZfT2
Copy link
Contributor Author

ZfT2 commented Jan 18, 2024

no problem, thanks for reviewing it :)

extended for Interest Charge Bookings
@buchen buchen merged commit 1d68cbc into portfolio-performance:master Jan 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants